[
https://issues.apache.org/jira/browse/SHINDIG-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256670#comment-13256670
]
[email protected] commented on SHINDIG-1752:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4789/#review7006
-----------------------------------------------------------
Ship it!
+1
- Stanton
On 2012-04-18 14:54:36, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4789/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-18 14:54:36)
bq.
bq.
bq. Review request for shindig and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default
post size will be 0 instead of the actual default size because
ContainerConfig.getInt returns 0 when the property is missing not null.
bq.
bq.
bq. This addresses bug SHINDIG-1752.
bq. https://issues.apache.org/jira/browse/SHINDIG-1752
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
1326802
bq.
bq. Diff: https://reviews.apache.org/r/4789/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran unit tests
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> When the property gadgets.jsonProxyUrl.maxPostSize is missing from the
> container.js the default post size ends up being 0 instead of using the
> default value
> ------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1752
> URL: https://issues.apache.org/jira/browse/SHINDIG-1752
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default
> post size will be 0 instead of the actual default size because
> ContainerConfig.getInt returns 0 when the property is missing not null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
