[
https://issues.apache.org/jira/browse/SHINDIG-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261035#comment-13261035
]
[email protected] commented on SHINDIG-1746:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4856/#review7188
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/SizeOfFilter.txt
<https://reviews.apache.org/r/4856/#comment15871>
Can you add any comments to this file? I am not sure if EHCache will allow
that but if so you might want to. It would also be good to add the Apache
license if you can.
- Ryan
On 2012-04-24 16:50:33, Stanton Sievers wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4856/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-24 16:50:33)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. See the JIRA for the high-level overview.
bq.
bq. I'm looking for feedback on how to best configure EhCache out-of-the-box
for Shindig. I've tried to pick configuration that makes sense for most simple
deployments.
bq.
bq. I'm also looking for feedback on how to best configure the SizeOf filter.
Right now I'm setting it in the system properties from the provider code but
could just as easily set it in the web.xml. I have it in the provider code
today because that's where we read in the rest of the config. Will security
manager's in real world deployments block the call to
System.getProperties().put()?
bq.
bq. More info on some of the issues I ran into and the approaches I took prior
to this: http://forums.terracotta.org/forums/posts/list/6940.page
bq.
bq.
bq. This addresses bug SHINDIG-1746.
bq. https://issues.apache.org/jira/browse/SHINDIG-1746
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/UPGRADING 1329784
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties
1329784
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java
1329784
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhConfiguredCache.java
1329784
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/SizeOfFilter.txt
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/ehcacheConfig.xml
1329784
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProviderTest.java
1329784
bq. http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1329784
bq.
bq. Diff: https://reviews.apache.org/r/4856/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Existing tests pass with the update. I'm not sure what else can be tested
via JUnit for these changes.
bq.
bq. In testing I did utilize JMX and heap dump analysis to understand and
verify that caches were being allocated appropriately. I have documented the
steps I took and will publish a wiki article once these changes are in.
bq.
bq.
bq. Thanks,
bq.
bq. Stanton
bq.
bq.
> Update EhCache configuration to use pooled resources for cache sizing
> ---------------------------------------------------------------------
>
> Key: SHINDIG-1746
> URL: https://issues.apache.org/jira/browse/SHINDIG-1746
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.5.0
> Reporter: Stanton Sievers
> Assignee: Stanton Sievers
> Labels: cache, caching
> Fix For: 2.5.0
>
>
> With EhCache 2.5.0 functionality was introduced to allow caches to be sized
> using bytes as an alternative to using the number of elements. One can also
> define the overall heap space that EhCache will use as well as what
> percentage of the overall cache's heap each named cache will use. See
> http://ehcache.org/documentation/configuration/cache-size#pooled-resources
> I would like to update Shindig to use this by default, as I think it should
> be the recommended method for configuring EhCache's use in Shindig
> out-of-the-box.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
