[
https://issues.apache.org/jira/browse/SHINDIG-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263650#comment-13263650
]
[email protected] commented on SHINDIG-1763:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4906/#review7299
-----------------------------------------------------------
Please use single quotes for Strings in javascript.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js
<https://reviews.apache.org/r/4906/#comment16116>
I saw some posts that say on IE you are supposed to use
window.navigator.userLanguage. The userLanguage property gets the language
from the Regional Settings in the control panel on windows as opposed to the
browser language. I assume navigator.language also works on IE, have you
tested this? If both properties work on IE, I guess it depends on whether we
want to be consistent across browsers or not, I think consistency is best.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js
<https://reviews.apache.org/r/4906/#comment16115>
I think some helper functions to get the lang and country make sense here.
I would suggest putting them in the util.js container file.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js
<https://reviews.apache.org/r/4906/#comment16114>
won't this override the lang and country property if they were already set
by the server? If they are already set I would rather us not do this logic and
use what the server told us to use.
- Ryan
On 2012-04-27 02:22:36, qiaoyun sun wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4906/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-27 02:22:36)
bq.
bq.
bq. Review request for Ryan Baxter and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. If we don't set this property in shindig.properties:
shindig.urlgen.use-templates-default=false, the lang and country info will not
pass to the ifr url, so the lang and country are ignored.
bq. For example: the ifr is like :
bq.
http://localhost:8080/shindig/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fshindig%2Fsamplecontainer%2Fexamples%2FSocialHelloWorld.xml&container=default&view=default&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=0a811629d8d99f87d3544b65058211fe&st=john.doe%3Ajohn.doe%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fshindig%252Fsamplecontainer%252Fexamples%252FSocialHelloWorld.xml%3Acont%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fshindig%252Fsamplecontainer%252Fexamples%252FSocialHelloWorld.xml%3A0%3Adefault%3A1335423393&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0
bq.
bq. They should be substituted by the browser's setting in client side.
bq.
bq.
bq. This addresses bug SHINDIG-1763.
bq. https://issues.apache.org/jira/browse/SHINDIG-1763
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js
1331177
bq.
bq. Diff: https://reviews.apache.org/r/4906/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. qiaoyun
bq.
bq.
> Container lang and country setting don't take effect
> ----------------------------------------------------
>
> Key: SHINDIG-1763
> URL: https://issues.apache.org/jira/browse/SHINDIG-1763
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0, 3.0.0
> Reporter: sun qiao yun
> Priority: Minor
> Attachments: lang_country.patch
>
>
> If we don't set this property in shindig.properties:
> shindig.urlgen.use-templates-default=false, the lang and country info will
> not pass to the ifr url, so the lang and country are ignored.
> For example: the ifr is like :
> http://localhost:8080/shindig/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fshindig%2Fsamplecontainer%2Fexamples%2FSocialHelloWorld.xml&container=default&view=default&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=0a811629d8d99f87d3544b65058211fe&st=john.doe%3Ajohn.doe%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fshindig%252Fsamplecontainer%252Fexamples%252FSocialHelloWorld.xml%3Acont%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fshindig%252Fsamplecontainer%252Fexamples%252FSocialHelloWorld.xml%3A0%3Adefault%3A1335423393&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0
> They should be substituted by the browser's setting in client side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
