[
https://issues.apache.org/jira/browse/SHINDIG-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267433#comment-13267433
]
[email protected] commented on SHINDIG-1762:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4976/#review7502
-----------------------------------------------------------
I think Ryan covered a lot of my other comments.
trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js
<https://reviews.apache.org/r/4976/#comment16602>
Can you utilize the constants you define in the EE constant.js here in this
code?
trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js
<https://reviews.apache.org/r/4976/#comment16606>
Can you use gadgets.log here instead? In fact, I see other places where
console.log is used and I'd like to avoid it if at all possible.
- Stanton
On 2012-05-02 23:24:37, Henry Saputra wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4976/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-02 23:24:37)
bq.
bq.
bq. Review request for shindig and Ryan Baxter.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Add code to handle EE extension for OpenSocial 2.5.0 core gadget spec:
bq. http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model
bq. http://docs.opensocial.org/display/OSD/Core-Gadget+-+Embedded+Experiences
bq.
bq. I remove the unneeded model for EmbeddedExperience because ActivityEntry
uses ExtendableBean, which act like a Map, to store opensocial and its
extension so there is no need to explicitly map embed or preferredExperience
with physical class:
bq.
java/social-api/src/main/java/org/apache/shindig/social/core/model/EmbeddedExperienceImpl.java
bq.
java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/EmbeddedExperience.java
bq.
bq.
bq. This addresses bug SHINDIG-1762.
bq. https://issues.apache.org/jira/browse/SHINDIG-1762
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/content/samplecontainer/examples/embeddedexperiences/BlogViewer.xml
PRE-CREATION
bq.
trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js
1333227
bq. trunk/content/sampledata/canonicaldb.json 1333227
bq.
trunk/features/src/main/javascript/features/embeddedexperiences/constant.js
1333227
bq.
trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js
1333227
bq.
trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js
1333227
bq.
trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js
1333227
bq.
trunk/features/src/test/javascript/features/embeddedexperiences/embedded_experiences_container_test.js
1333227
bq.
trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/EmbeddedExperienceImpl.java
1333227
bq.
trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/EmbeddedExperience.java
1333227
bq.
trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonActivityEntryTest.java
1333227
bq.
trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json
1333227
bq.
trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json
1333227
bq.
trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java
1333227
bq.
bq. Diff: https://reviews.apache.org/r/4976/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated the unit tests and modify EE sample gadget to test passing
additional context and respect preferredExperience display link text.
bq.
bq.
bq. Thanks,
bq.
bq. Henry
bq.
bq.
> Add code to handle OpenSocial Embedded Experience Container Context extension
> per http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model
> ----------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1762
> URL: https://issues.apache.org/jira/browse/SHINDIG-1762
> Project: Shindig
> Issue Type: New Feature
> Components: Java, Javascript
> Affects Versions: 2.5.0-beta1, 2.5.0
> Reporter: Henry Saputra
> Assignee: Henry Saputra
>
> Add code to handle EE extension for OpenSocial 2.5.0 core gadget spec:
> http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model
> http://docs.opensocial.org/display/OSD/Core-Gadget+-+Embedded+Experiences
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
