[
https://issues.apache.org/jira/browse/SHINDIG-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268511#comment-13268511
]
[email protected] commented on SHINDIG-1762:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4976/
-----------------------------------------------------------
(Updated 2012-05-04 16:29:28.042006)
Review request for shindig and Ryan Baxter.
Changes
-------
Updated based latest comments.
Summary
-------
Add code to handle EE extension for OpenSocial 2.5.0 core gadget spec:
http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model
http://docs.opensocial.org/display/OSD/Core-Gadget+-+Embedded+Experiences
I remove the unneeded model for EmbeddedExperience because ActivityEntry uses
ExtendableBean, which act like a Map, to store opensocial and its extension so
there is no need to explicitly map embed or preferredExperience with physical
class:
java/social-api/src/main/java/org/apache/shindig/social/core/model/EmbeddedExperienceImpl.java
java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/EmbeddedExperience.java
This addresses bug SHINDIG-1762.
https://issues.apache.org/jira/browse/SHINDIG-1762
Diffs (updated)
-----
trunk/content/sampledata/canonicaldb.json 1333592
trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js
1333592
trunk/content/samplecontainer/examples/embeddedexperiences/BlogViewer.xml
PRE-CREATION
trunk/features/src/main/javascript/features/embeddedexperiences/constant.js
1333592
trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js
1333592
trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js
1333592
trunk/features/src/main/javascript/features/embeddedexperiences/feature.xml
1333592
trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js
1333592
trunk/features/src/test/javascript/features/embeddedexperiences/embedded_experiences_container_test.js
1333592
trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/EmbeddedExperienceImpl.java
1333592
trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/EmbeddedExperience.java
1333592
trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonActivityEntryTest.java
1333592
trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json
1333592
trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json
1333592
trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java
1333592
Diff: https://reviews.apache.org/r/4976/diff
Testing
-------
Updated the unit tests and modify EE sample gadget to test passing additional
context and respect preferredExperience display link text.
Thanks,
Henry
> Add code to handle OpenSocial Embedded Experience Container Context extension
> per http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model
> ----------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1762
> URL: https://issues.apache.org/jira/browse/SHINDIG-1762
> Project: Shindig
> Issue Type: New Feature
> Components: Java, Javascript
> Affects Versions: 2.5.0-beta1, 2.5.0
> Reporter: Henry Saputra
> Assignee: Henry Saputra
>
> Add code to handle EE extension for OpenSocial 2.5.0 core gadget spec:
> http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model
> http://docs.opensocial.org/display/OSD/Core-Gadget+-+Embedded+Experiences
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
