[ 
https://issues.apache.org/jira/browse/SHINDIG-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stanton Sievers updated SHINDIG-1771:
-------------------------------------

    Description: 
At runtime, feature JavaScript is closure compiled at varying compilation 
levels depending on settings in shindig.properties and other debug flags.  If 
there are compile errors, closure will return an error and this will eventually 
result in an error back to the client that requested the features.  

A better approach would be to compile each feature at build time as part of the 
JUnit execution and report errors there.  This would allow any JavaScript 
errors to be caught at build time instead of runtime.

To be clear, I'm not recommending a change to any of the runtime compilation 
behavior.  That would stay exactly the same.  This is simply extra testing we 
can do at build time to find errors.

  was:
At runtime, feature JavaScript is closure compiled at varying compilation 
levels depending on settings in shindig.properties and other debug flags.  If 
there are compile errors, closure will return an error and this will eventually 
result in an error back to the client that requested the features.  

A better approach would be to compile each feature at build time as part of the 
JUnit execution and report errors there.  This would allow any JavaScript 
errors to be caught at build time instead of runtime.

    
> Closure compile all feature JavaScript as part of JUnit execution to ensure 
> no JavaScript errors at build time
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1771
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1771
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java, Javascript 
>            Reporter: Stanton Sievers
>
> At runtime, feature JavaScript is closure compiled at varying compilation 
> levels depending on settings in shindig.properties and other debug flags.  If 
> there are compile errors, closure will return an error and this will 
> eventually result in an error back to the client that requested the features. 
>  
> A better approach would be to compile each feature at build time as part of 
> the JUnit execution and report errors there.  This would allow any JavaScript 
> errors to be caught at build time instead of runtime.
> To be clear, I'm not recommending a change to any of the runtime compilation 
> behavior.  That would stay exactly the same.  This is simply extra testing we 
> can do at build time to find errors.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to