[
https://issues.apache.org/jira/browse/SHINDIG-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272505#comment-13272505
]
[email protected] commented on SHINDIG-1774:
--------------------------------------------------------
bq. On 2012-05-10 17:00:08, Stanton Sievers wrote:
bq. > Please take a look at
https://issues.apache.org/jira/browse/SHINDIG-1533. It tried to address this
issue earlier by allowing one to define a window global to specify the ID of
the script tag.
bq. >
That functionality remains. This code adds the logic to try and find the
correct script if the window global id is not defined. I can see an implementer
not realizing the id needed to be define when they include Javascript below the
JSservlet URL.
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5087/#review7777
-----------------------------------------------------------
On 2012-05-10 16:46:50, Mike May wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5087/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-10 16:46:50)
bq.
bq.
bq. Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. init.js assumes the feature URL for the JS servlet is the last script tag
when this will not always be the case.
bq.
bq.
bq. This addresses bug SHINDIG-1774.
bq. https://issues.apache.org/jira/browse/SHINDIG-1774
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/init.js
1336780
bq.
bq. Diff: https://reviews.apache.org/r/5087/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All tests pass.
bq.
bq. Local testing done.
bq.
bq.
bq. Thanks,
bq.
bq. Mike
bq.
bq.
> init.js blindly assumes that the JS servlet feature URL is the last script
> tag defined
> --------------------------------------------------------------------------------------
>
> Key: SHINDIG-1774
> URL: https://issues.apache.org/jira/browse/SHINDIG-1774
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta1
> Reporter: Michael May
> Priority: Trivial
> Labels: javascript
> Attachments: init.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> init.js assumes the feature URL for the JS servlet is the last script tag
> when this will not always be the case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
