[
https://issues.apache.org/jira/browse/SHINDIG-1770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272509#comment-13272509
]
[email protected] commented on SHINDIG-1770:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5070/#review7786
-----------------------------------------------------------
Ship it!
+1
- Henry
On 2012-05-08 19:17:32, Stanton Sievers wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5070/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-08 19:17:32)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I had initially made the change in JsServlet itself to check for errors
before calling emitJsResponse, however, DefaultJsServingPipeline.process()
seemed like a better place. JsServingPipeline.process' javadoc indicates the
method should throw an exception if any of the processing steps resulted in an
error, so it seems reasonable to check for errors and throw before returning.
bq.
bq. Jira text:
bq. Currently if JsServlet encounters an error processing a response, such as
a closure compile error, it will simply respond with the error status code but
won't respond with an error message. To improve this behavior, I'd like to have
the servlet send a proper error response with the error status code and the
error string.
bq.
bq.
bq. This addresses bug SHINDIG-1770.
bq. https://issues.apache.org/jira/browse/SHINDIG-1770
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/DefaultJsServingPipeline.java
1335416
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/JsServletTest.java
1335416
bq.
bq. Diff: https://reviews.apache.org/r/5070/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added a new test in JsServlet to ensure the error makes it through.
bq.
bq. Manually introduced JavaScript errors that would cause Closure to complain
and verified that the error text and status code made it through when hitting
the JsServlet in the browser.
bq.
bq.
bq. Thanks,
bq.
bq. Stanton
bq.
bq.
> Improve JsServlet to respond with an error and error message if there was a
> problem
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1770
> URL: https://issues.apache.org/jira/browse/SHINDIG-1770
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.5.0
> Reporter: Stanton Sievers
> Assignee: Stanton Sievers
> Fix For: 2.5.0
>
>
> Currently if JsServlet encounters an error processing a response, such as a
> closure compile error, it will simply respond with the error status code but
> won't respond with an error message. To improve this behavior, I'd like to
> have the servlet send a proper error response with the error status code and
> the error string.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
