[
https://issues.apache.org/jira/browse/SHINDIG-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272545#comment-13272545
]
jirapos...@reviews.apache.org commented on SHINDIG-1767:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5067/
-----------------------------------------------------------
(Updated 2012-05-10 17:49:50.232626)
Review request for shindig.
Changes
-------
Thanks for finding that pretty awesome bug, Stanton. :)
Last call for reviews. I'll commit tomorrow unless anyone lets me know they
need more time.
Summary
-------
With the latest changes from
https://issues.apache.org/jira/browse/SHINDIG-1766, the auto adjust of
dynamic-height and dynamic-width features was broken.
The webkit height calculation is now the most reliable means of obtaining the
content height/width of the gadget in every browser I've tested, so I cleaned
that up for either height or width and moved it to the common feature.
This addresses bug SHINDIG-1767.
https://issues.apache.org/jira/browse/SHINDIG-1767
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/DynamicSizeDemo.xml
1333997
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/DynamicSizeDemoHTML5.xml
PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/dynamic-height-height.js
1333997
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/dynamic-size-util.js
1333997
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/feature.xml
1333997
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js
1333997
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/dynamic-width.js
1333997
Diff: https://reviews.apache.org/r/5067/diff
Testing
-------
Tested in IE 7,8,9 Chrome, FF using quirks and html5
Thanks,
Dan
> Gadgets using gadgets.window.adjustHeight are no longer adjusting to the
> correct height
> ---------------------------------------------------------------------------------------
>
> Key: SHINDIG-1767
> URL: https://issues.apache.org/jira/browse/SHINDIG-1767
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Dan Dumont
>
> I am noticing that gadgets calling gadgets.window.adjustHeight are no longer
> agdjusting their height in the common container. For example try the ToDo
> gadget in the common container and you will notice the iframe will not grow
> to fit the whole gadget, however there will be a scroll bar allowing you to
> scroll.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
