[
https://issues.apache.org/jira/browse/SHINDIG-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276705#comment-13276705
]
[email protected] commented on SHINDIG-1777:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5113/#review7930
-----------------------------------------------------------
New patch lgtm
- Dan
On 2012-05-15 19:14:23, Erin Noe-Payne wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5113/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-15 19:14:23)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq.
bq. pubsub-2 appends an rpc token with a hashtag to the open gadget url. When
the url parameters are split by '&', hash tags are skipped and json.parse fails
on the resulting parameter.
bq.
bq. Switched to global replace to avoid the issue.
bq.
bq.
bq. This addresses bug SHINDIG-1777.
bq. https://issues.apache.org/jira/browse/SHINDIG-1777
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js
1338216
bq.
bq. Diff: https://reviews.apache.org/r/5113/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Chrome, FF 12, IE 8/9
bq.
bq.
bq. Thanks,
bq.
bq. Erin
bq.
bq.
> OpenViews / pubsub-2 conflict
> -----------------------------
>
> Key: SHINDIG-1777
> URL: https://issues.apache.org/jira/browse/SHINDIG-1777
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0-beta1
> Reporter: Erin Noe-Payne
> Priority: Minor
> Labels: openviews, pubsub, rpctoken
> Fix For: 2.5.0-beta1
>
> Original Estimate: 8h
> Remaining Estimate: 8h
>
> To reproduce:
> 1) Create a gadget that requires both open-views and pubsub-2 features.
> 2) Make a call to gadgets.views.openGadget(), passing a viewParams object
> 3) In the newly opened gadget, make a call to gadgets.views.getParams(). You
> will receive an empty object, regardless of what was passed as a parameter.
> What's happening?
> 1) It looks like pubsub-2 appends an rpc token to the open gadget url in the
> form of #rpctoken=nzZsoU
> 2) The resulting url param for views looks like this - view-params:
> "{"value":"yarrrgh","retVal":""}#rpctoken=nzZsoU"
> 2) In the views feature, views.js, line 120: The param goes through
> json.parse, which fails and returns an empty object
> This will probably affect more than just the openviews feature.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
