[
https://issues.apache.org/jira/browse/SHINDIG-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278938#comment-13278938
]
[email protected] commented on SHINDIG-1781:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5162/#review7972
-----------------------------------------------------------
Ship it!
LGTM. Having an additional MakeRequestHandlerTest that verifies that the
user-agent is ferried along would be a welcome addition to the patch.
- Stanton
On 2012-05-18 16:21:01, Adam Clarke wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5162/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-18 16:21:01)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Passes the User-Agent header so intermediate (or even backend processing)
can make browser-specific customizations.
bq.
bq.
bq. This addresses bug SHINDIG-1781.
bq. https://issues.apache.org/jira/browse/SHINDIG-1781
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
1340074
bq.
bq. Diff: https://reviews.apache.org/r/5162/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. Adam
bq.
bq.
> makeRequest does not forward User-Agent
> ---------------------------------------
>
> Key: SHINDIG-1781
> URL: https://issues.apache.org/jira/browse/SHINDIG-1781
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.5.0-beta1, 2.5.0
> Reporter: Adam Clarke
> Priority: Minor
> Attachments: 1781_20120518.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Currently makeRequest does not forward the User-Agent header from the
> browser. This makes it impossible for intermediate processing or backend
> processing to customize responses for different browsers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
