Henry Saputra created SHINDIG-1789:
--------------------------------------
Summary: Set the container context outside the callback in the
open-views/open-views-ee-cotainer.js
Key: SHINDIG-1789
URL: https://issues.apache.org/jira/browse/SHINDIG-1789
Project: Shindig
Issue Type: Bug
Affects Versions: 2.5.0-beta1
Reporter: Henry Saputra
Assignee: Henry Saputra
Fix For: 2.5.0-beta2
>From Dan Dumont:
Henry, sorry for the late review, but it looks like the code you added to the
open-views ee feature doesn't account for async element creation.
The review site is down now, but it looks like in the code if the element is
created async, the augmented context will never get passed to the callback.
I don't see why it ever needs to be passed to the callback, why can't you init
the context before you define the callback and use the outer scope reference
instead of passing it in?
See https://issues.apache.org/jira/browse/SHINDIG-1762
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
