[
https://issues.apache.org/jira/browse/SHINDIG-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Dumont updated SHINDIG-1864:
--------------------------------
Description:
The container will now handle the launching of oauth requests and fire onopen
and onclose events back into the requesting gadgets. This will allow container
implementations to override the default behavior and possibly surface them in
liteboxes rather than relying on window.open which is often prevented by popup
blockers.
This also paves the way for enhancements such as doing an oauth dance before a
gadget even renders for pipelined data that is oauth protected.
---------------------------
All oauthpopup changes made up until they were reverted are in the attached
patch. There still exists a problem when this patch is applied where gadgets on
a locked domain cannot complete the oauth dance.
This problem is discussed in this review: https://reviews.apache.org/r/7186/
was:
The container will now handle the launching of oauth requests and fire onopen
and onclose events back into the requesting gadgets. This will allow container
implementations to override the default behavior and possibly surface them in
liteboxes rather than relying on window.open which is often prevented by popup
blockers.
This also paves the way for enhancements such as doing an oauth dance before a
gadget even renders for pipelined data that is oauth protected.
> Change oauthpopup feature to do window.open call from the container page
> ------------------------------------------------------------------------
>
> Key: SHINDIG-1864
> URL: https://issues.apache.org/jira/browse/SHINDIG-1864
> Project: Shindig
> Issue Type: Improvement
> Components: Java, Javascript
> Reporter: Dan Dumont
> Assignee: Dan Dumont
> Attachments: shindig-project-upstream.patch
>
>
> The container will now handle the launching of oauth requests and fire onopen
> and onclose events back into the requesting gadgets. This will allow
> container implementations to override the default behavior and possibly
> surface them in liteboxes rather than relying on window.open which is often
> prevented by popup blockers.
> This also paves the way for enhancements such as doing an oauth dance before
> a gadget even renders for pipelined data that is oauth protected.
> ---------------------------
> All oauthpopup changes made up until they were reverted are in the attached
> patch. There still exists a problem when this patch is applied where gadgets
> on a locked domain cannot complete the oauth dance.
> This problem is discussed in this review: https://reviews.apache.org/r/7186/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
