[
https://issues.apache.org/jira/browse/SHINDIG-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13666235#comment-13666235
]
Stanton Sievers commented on SHINDIG-1917:
------------------------------------------
I had a minor issue applying the patch when it came to canonicaldb.json. I
haven't quite figured out why.
I ignored the minor patch issue and everything built fine locally. I did get a
warning from maven: "[WARNING] The requested profile "samples" could not be
activated because it does not exist." I still had "samples" listed a profile
in my run config in Eclipse. I tried this on my Jenkins server and it halted
the build. Before these changes go in, we'll need to make sure our doc on the
wiki is up-to-date and that it doesn't tell people to build "samples" anymore.
We'll have also need to ensure that the jobs on builds.a.o are updated or else
they will start failing.
Is there anything that should be tested with this change?
> Remove Java sample module from source control for final Shindig 2.5.0 release
> -----------------------------------------------------------------------------
>
> Key: SHINDIG-1917
> URL: https://issues.apache.org/jira/browse/SHINDIG-1917
> Project: Shindig
> Issue Type: Task
> Affects Versions: 2.5.0-beta6
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Fix For: 2.5.0
>
> Attachments: SHINDIG-1917.patch
>
>
> Remove Java sample module from source control for final Shindig 2.5.0 release
> because its blocking the final release with error from JPA and hibernate
> binding.
> VOTE thread was sent to dev and users lists and got two +1 binding votes to
> remove it with no -1 and 0.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
