Andreas Kohn created SHINDIG-1968:
-------------------------------------

             Summary: Create CollectionOptions via a ~Factory instead of 
explicitly constructing them
                 Key: SHINDIG-1968
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1968
             Project: Shindig
          Issue Type: Improvement
          Components: Java
    Affects Versions: 2.5.0-update1
            Reporter: Andreas Kohn
            Assignee: Andreas Kohn


CollectionOptions instances are explicitly constructed via "new". For 
integrations CollectionOptions is also the ideal place to add additional 
parameter handling, without having to copy/paste the *Handler/*Service code.

In our specific case we are working with a different approach to filtering and 
searching that depends on additional parameters, as the existing ones from 
OpenSocial are simply not sufficient.

The patch in the review introduces a CollectionOptionsFactory with the obvious 
implementation, and changes the handlers to get that factory injected. In our 
integration we bind() the factory to our specific implementation that handles 
our parameters.

Issue was briefly discussed at 
http://mail-archives.apache.org/mod_mbox/shindig-dev/201402.mbox/%3CCAApR0qr8-pyko_CH9AvOhvsUZ_12L_b2rtAB-O6tb6JUtRyX8Q%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to