[ 
https://issues.apache.org/jira/browse/SHINDIG-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134027#comment-14134027
 ] 

Doug Davies commented on SHINDIG-1984:
--------------------------------------

For now I am using my patched RequestPipleline which turns off caching for all 
oauth2 request.

   public HttpResponse execute(HttpRequest request) throws GadgetException {
       if (request.getAuthType() == AuthType.OAUTH2) {
           request.setIgnoreCache(true);
       }
       return super.execute(request);
   }

but not the right solution.

> When doing an OAUTH2 flow the first request to the service that returns the 
> oauthApprovalUrl probably shouldn’t be cached or set in the staleResponse
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1984
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1984
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 2.5.1
>            Reporter: Doug Davies
>            Priority: Minor
>
> When doing an OAUTH2 flow the first request to the service that returns the 
> oauthApprovalUrl probably shouldn’t be cached or set in the staleResponse, 
> because then it could possibly be used on the response for the ACTUAL request 
> if it returns a 500.  Thus an endless loop of display the approval url and 
> making the service call.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to