jbampton commented on issue #2383: URL: https://github.com/apache/shiro/issues/2383#issuecomment-3614293692
We have pre-commit running with GitHub Actions. But pre-commit is designed to run on your local machine they are commit hooks that run on `git commit`. So by running the pre-commit tests locally you find the issues first before pushing up to the GitHub CI which saves a lot of time. So you have not installed pre-commit and the hooks locally but I have and that is what everyone does that uses git hooks: https://pre-commit.com "Git hook scripts are useful for identifying simple issues before submission to code review. We run our hooks on every commit to automatically point out issues in code such as missing semicolons, trailing whitespace, and debug statements. By pointing these issues out before code review, this allows a code reviewer to focus on the architecture of a change while not wasting time with trivial style nitpicks." pre-commit is a Python package: https://pypi.org/project/pre-commit/ Have a quick read of some docs I wrote for Apache CloudStack on pre-commit https://github.com/apache/cloudstack/blob/main/PRE_COMMIT.md Also some Apache projects integrate Makefiles for convenience to run the pre-commit commands. Example: https://github.com/apache/tooling-trusted-releases/blob/d9de04989ab694cc84836565824e8b4e165b3b54/Makefile#L31 Also Apache Airflow is a huge git hooks user. They have about 900 lines in their pre-commit config https://github.com/apache/airflow/blob/main/.pre-commit-config.yaml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
