[ 
https://issues.apache.org/jira/browse/SIS-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Desruisseaux resolved SIS-570.
-------------------------------------
    Resolution: Fixed

> Assign loggers to static final fields
> -------------------------------------
>
>                 Key: SIS-570
>                 URL: https://issues.apache.org/jira/browse/SIS-570
>             Project: Spatial Information Systems
>          Issue Type: Task
>          Components: Coverage, Features, GUI, Metadata, Referencing, Storage, 
> Utilities
>    Affects Versions: 1.3
>            Reporter: Martin Desruisseaux
>            Assignee: Martin Desruisseaux
>            Priority: Major
>             Fix For: 1.4
>
>
> Most of the time during logging, SIS fetches the logger by a call to 
> {{Logger.getLogger(String)}} at each log event. The recommended practice is 
> rather to assign the logger in a static field instead, in order to keep the 
> configuration stable (otherwise the {{Logger}} instance may be garbage 
> collected and its configuration lost). It may also have a performance 
> advantage, but uncertain given that the majority of SIS logging are for 
> reporting recoverable exceptions.
> We should replace many (not all) calls to {{Logger.getLogger(String)}} by 
> static constants. We do not necessarily replace all calls because we do not 
> want to make those loggers visible in public API and we may want to keep the 
> unconditional creation of {{Logger}} in e.g. the root of a hierarchy of 
> classes using that logger.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to