hboutemy commented on code in PR #36:
URL: https://github.com/apache/sis/pull/36#discussion_r1267575816
##########
pom.xml:
##########
@@ -545,6 +545,7 @@
=================================================================== -->
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+
<project.build.outputTimestamp>2023-07-15T16:42:39Z</project.build.outputTimestamp>
Review Comment:
on the maintenance mechanism: it can be maven-release-plugin, or
versions-maven-plugin. Or if you prefer, you can use the git commit date, or
even choose to not update the value and keep it at a conventional value: see
https://maven.apache.org/guides/mini/guide-reproducible-builds.html#faq (sorry,
I overlooked the fact that you don't use the maven-release-plugin)
Honestly, merging is not really something that happens, given the timestamp
is only updated usually at most during version changes (between SNAPSHOT and
release)
on why binary check vs smart tools:
- smart tools will have bugs
- efficiency (it's not only about timestamp, but also order)
- particularly in the case of cache mechanisms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@sis.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
