[ 
https://issues.apache.org/jira/browse/SIS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Johann Sorel resolved SIS-188.
------------------------------
    Resolution: Fixed

Class renamed to DBFField.
it is still visible, as requested to have access to a low level API.
The visible fields have been reduced and class been made immutable.

> Hide FieldDescriptor (a DBase3 internal format structure)
> ---------------------------------------------------------
>
>                 Key: SIS-188
>                 URL: https://issues.apache.org/jira/browse/SIS-188
>             Project: Spatial Information Systems
>          Issue Type: Sub-task
>          Components: Shapefile
>            Reporter: Martin Desruisseaux
>            Assignee: Johann Sorel
>            Priority: Major
>              Labels: JDBC, Shapefile
>
> The {{org.apache.sis.storage.shapefile}} package contains a 
> {{FieldDescriptor}} public class, which contain information that look likes 
> very specific to the internal of DBase format. For example:
> * Field name as an array of bytes (this is not what user would usually 
> handle, which are rather {{String}} objects)
> * Field address in memory (maybe an heritage from C/C++ ?)
> * DBase+ Lan Reserved 2 (not sure what it is, documentation only said 
> "reserved 2")
> Those internal details should not be visible to the users. I suggest to 
> either declare the class package-privated, or move it to an internal package.
> The {{FieldDescriptors}} class, which is a list of {{FieldDescriptor}}, 
> should also move in the same way.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to