KontainPluton commented on code in PR #40:
URL: https://github.com/apache/sis/pull/40#discussion_r2833618107
##########
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/FileService.java:
##########
@@ -93,6 +96,42 @@ public class FileService extends FileSystemProvider {
*/
private static final String DEFAULT_ACCESS_KEY = "";
+ /**
+ * An arbitrary string used as part of the key in the {@link #fileSystems}
map
+ * when the user did not specified explicitly a host.
+ * In such case, the default host is the amazon host and is defined with
the region.
+ *
+ * Host can also be defined with:
+ * <ul>
+ * <li>{@code s3.hostUrl} Java system properties.</li>
Review Comment:
Replaced by org.apache.sis.s2.hostURL
Same replacement on port and isHttps
##########
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/FileService.java:
##########
@@ -75,6 +77,7 @@
* instead of the data to access, and can be a global configuration for the
server.
*
* @author Martin Desruisseaux (Geomatys)
+ * @author Quentin Bialota (Geomatys)
* @version 1.5
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
