[ 
https://issues.apache.org/jira/browse/SOLR-13608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315476#comment-17315476
 ] 

ASF subversion and git services commented on SOLR-13608:
--------------------------------------------------------

Commit a557f071ca405948d835c3f7b0ed8a05cfde0625 in lucene-solr's branch 
refs/heads/branch_8x from Jason Gerlowski
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=a557f07 ]

SOLR-13608: Sync on TrackingBackupRepo NL changes

BackupRepositoryFactory has a special case in its 'newInstance' method.
For 'TrackingBackupRepository' instances, BRF will modify a NamedList
representing the TBF config - adding references to the
SolrResourceLoader and to BRF itself.

In isolation this is innocuous, but becomes a problem when
BRF.newInstance is called concurrently from different threads. Threads
can race to set these NamedList keys, corrupting the NamedList in the
process.  (i.e. NamedList vals ended up in 'key' indices, and vice versa)

This commit adds synchronization to this NL initialization, to ensure
that the NL values are only set by a single thread.


> Incremental backup for Solr
> ---------------------------
>
>                 Key: SOLR-13608
>                 URL: https://issues.apache.org/jira/browse/SOLR-13608
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Cao Manh Dat
>            Assignee: Jason Gerlowski
>            Priority: Major
>             Fix For: main (9.0), 8.9
>
>          Time Spent: 83h
>  Remaining Estimate: 14h
>
> SIP-12 lays out a plan for adding support for incremental backups to Solr.  
> At a high level, the idea is that Solr will be able to store multiple backups 
> in the same location, and backups beyond the first one will only upload those 
> files that were not uploaded by previous backups.
> This involves changes to the file structure within a particular backup 
> location.  It also entails changes to some of the backup/restore API 
> parameters and semantics, to accommodate storing multiple backups in the same 
> place, etc.
> This ticket covers the changes required for this functionality, as described 
> in SIP-12 unless mentioned specifically below.  It does not implement all of 
> [SIP-12.|https://cwiki.apache.org/confluence/display/SOLR/SIP-12%3A+Incremental+Backup+and+Restore]
>   Same-collection-restoration, support for popular proprietary blob stores, 
> etc. are left for separate tickets in an attempt to keep PRs manageable and 
> conceptually cohesive. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to