thelabdude commented on a change in pull request #253:
URL: https://github.com/apache/solr-operator/pull/253#discussion_r610772940
##########
File path: controllers/util/zk_util.go
##########
@@ -85,6 +85,10 @@ func GenerateZookeeperCluster(solrCloud *solr.SolrCloud,
zkSpec *solr.ZookeeperS
zkCluster.Spec.Pod.NodeSelector =
zkSpec.ZookeeperPod.NodeSelector
}
+ if zkSpec.ZookeeperPod.Env != nil {
+ zkCluster.Spec.Pod.Env = zkSpec.ZookeeperPod.Env
Review comment:
Good catch! Thanks ... always seem to forget about these. I added a
basic test for this but only looking at the env ... maybe I should bite the
bullet and test all of those fields?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
