bruno-roustant commented on a change in pull request #68:
URL: https://github.com/apache/solr/pull/68#discussion_r613031089
##########
File path:
solr/contrib/blob-directory/src/java/org/apache/solr/blob/BlobDirectory.java
##########
@@ -181,7 +182,12 @@ protected void ensureOpen() throws AlreadyClosedException {
@Override
public void close() throws IOException {
// Free the reference to the IndexOutput.
- blobFileSupplier.indexOutput = null;
+ blobFileSupplier.getBlobFile();
+ // TODO
+ // It could be possible to start pushing the file asynchronously with
BlobPusher at this time,
Review comment:
In this BlobIndexOutput we could intercept the writeXXX() methods to
start pushing to the BlobPusher, this would require buffering. I'll add this
option in the comment, and this will definitely require some perf benchmarking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
