gerlowskija commented on a change in pull request #39:
URL: https://github.com/apache/solr/pull/39#discussion_r616854392
##########
File path:
solr/core/src/java/org/apache/solr/core/backup/repository/BackupRepository.java
##########
@@ -142,6 +142,7 @@ default String getBackupLocation(String override) {
*/
OutputStream createOutput(URI path) throws IOException;
+ // TODO define whether this should also create any nonexistent parent
directories. (i.e. is this 'mkdir', or 'mkdir -p')
Review comment:
> I'm not sure if there are use cases where we don't want to create
parent directories if needed.
Good question. There's no obvious use case in the backup code afaik. Though
I could see an argument that **not** creating parent directories is a safer
API, as it'd throw an error if a consumer misspelled a dirname, etc. (Not
saying that's how I'd lean, just thinking aloud.)
Anyway, I created a JIRA here per your suggestion:
https://issues.apache.org/jira/browse/SOLR-15359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
