epugh commented on pull request #41: URL: https://github.com/apache/solr/pull/41#issuecomment-824766011
> Hey @epugh I pushed up a few fixes for my previous review comments. > > In the process though I noticed something odd. On certain API calls, the docs still have two sets of examples. Take `DELETEREPLICA` in `replica-management.adoc` for example. The section gives a short overview, then has some tabbed v1/v2 examples, then it has detailed description for each API parameter. All great so far! But then before the next API command, it gives _more_ DELETEREPLICA examples. > > In some cases (e.g. ADDREPLICA) the second set of examples are different enough from the first set that they might provide value. But in other cases it looks like the two sets of examples are near duplicates and we just forgot to remove them. > > Was this something you did thoughtfully? Or was it just an oversight? Happy to go through and fix myself - just wanted to make sure I wasn't undoing something you did intentionally. If you are in there, I think go ahead and delete them! I think I ended up changing the structure to make the v1 and v2 examples always at the top, and then the more detailed down below, that might have caused some duplicates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
