[ 
https://issues.apache.org/jira/browse/SOLR-15367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329953#comment-17329953
 ] 

David Smiley commented on SOLR-15367:
-------------------------------------

"rid" supports a user-specified parameter of "rid".  If we go with this issue, 
then it would only be supported as an HTTP header, whatever we choose to name 
it.  That should be fine, I think.

One snag is that TracerConfigurator doesn't provide the CoreContainer that is 
needed to give the hostname to this custom TracerConfigurator, which is what 
the current "rid" solution does so that hosts generating these IDs are 
differentiated.  This seems to be a Solr internal platform limitation -- we 
have SolrCoreAware and other similar things but I don't see CoreContainerAware 
or something similar.  The hostname comes into CoreContainer on the NodeConfig 
object.

> Convert "rid" functionality into a default Tracer
> -------------------------------------------------
>
>                 Key: SOLR-15367
>                 URL: https://issues.apache.org/jira/browse/SOLR-15367
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: David Smiley
>            Priority: Major
>
> Solr's "rid" (request ID) functionality added in SOLR-14566 could be 
> converted into a distributed-tracing OpenTracing Tracer (Solr 
> TracerConfigurator) plugin, more or less.  Such an implementation, enabled by 
> default, would merely generate IDs and pass them along in a custom HTTP 
> header.  Solr's existing tracing support would then ensure that this ID is in 
> MDC in the "t:" log prefix, and thus would fit in nicely.  "rid" is kind of a 
> cheap bolt-on by comparison, duplicative with tracing but far fewer features. 
>  Solr's tracing support is growing, supporting more Solr-to-Solr interaction 
> than "rid" which is only in a search request.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to