[
https://issues.apache.org/jira/browse/SOLR-15334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17330476#comment-17330476
]
Uwe Schindler commented on SOLR-15334:
--------------------------------------
The problem happens here:
https://github.com/apache/solr/blob/749af1b7c991cd4db5761e4e1a39c8c4d16c03cd/solr/core/src/test/org/apache/solr/security/TestPKIAuthenticationPlugin.java#L74
This line is executed BEFORE the test case is setUp():
https://github.com/apache/solr/blob/749af1b7c991cd4db5761e4e1a39c8c4d16c03cd/solr/core/src/test/org/apache/solr/security/TestPKIAuthenticationPlugin.java#L90
The code that creates the mock needs to be delayed so it happens AFTER the
test's setUp().
> PKIAuthenticationPlugin should return error on failed authentication
> --------------------------------------------------------------------
>
> Key: SOLR-15334
> URL: https://issues.apache.org/jira/browse/SOLR-15334
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Mike Drob
> Assignee: Mike Drob
> Priority: Major
> Fix For: main (9.0)
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Right now in PKIAuthenticationPlugin, when we fail authentication for
> whatever reason, we will still delegate to the rest of the filter chain and
> then return true. According to the javadoc, however, we should be returning
> false or throwing an exception.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
