dsmiley commented on a change in pull request #107:
URL: https://github.com/apache/solr/pull/107#discussion_r624363811
##########
File path:
solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java
##########
@@ -253,7 +252,9 @@ public void writeResults(ResultContext ctx, JavaBinCodec
codec) throws IOExcepti
createJavaBinCodec(callback,
resolver).setWritableDocFields(resolver).marshal(rsp.getValues(), out);
try (InputStream in = out.toInputStream()) {
- return (NamedList<Object>) new
JavaBinCodec(resolver).unmarshal(in);
+ @SuppressWarnings({"unchecked"})
+ NamedList<Object> resolved = (NamedList<Object>) new
JavaBinCodec(resolver).unmarshal(in);
Review comment:
does a one-liner no longer work as it was?
##########
File path: solr/test-framework/src/java/org/apache/solr/cloud/ZkTestServer.java
##########
@@ -644,8 +644,10 @@ public void shutdown() throws IOException,
InterruptedException {
while (true) {
try {
- zooThread.join();
- ObjectReleaseTracker.release(zooThread);
+ if (zooThread != null) {
Review comment:
belongs in another issue?
##########
File path: solr/core/src/java/org/apache/solr/handler/StreamHandler.java
##########
@@ -141,15 +141,21 @@ public static void addExpressiblePlugins(StreamFactory
streamFactory, SolrCore c
}
public static class ExpressibleHolder extends PackagePluginHolder<Class<?
extends Expressible>> {
+ private Class<? extends Expressible> clazz;
+
public ExpressibleHolder(PluginInfo info, SolrCore core,
SolrConfig.SolrPluginInfo pluginMeta) {
super(info, core, pluginMeta);
}
- // WARNING: This is called from the super constructor, do not make
assumptions about object state.
- // This will probably cause a really bad bug someday, I hope you are
reading this under better circumstances.
+ @Override
Review comment:
The commit "potential class loading issue" is not related to the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
