alessandrobenedetti commented on a change in pull request #58:
URL: https://github.com/apache/solr/pull/58#discussion_r628159012
##########
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/model/MultipleAdditiveTreesModel.java
##########
@@ -170,19 +170,21 @@ public boolean isLeaf() {
}
public float score(float[] featureVector) {
- if (isLeaf()) {
- return value;
- }
-
- // unsupported feature (tree is looking for a feature that does not
exist)
- if ((featureIndex < 0) || (featureIndex >= featureVector.length)) {
- return 0f;
- }
+ RegressionTreeNode regressionTreeNode = this;
Review comment:
RegressionTreeNode regressionTreeNode
I am usually not a big fan of type = variable name approach, not much
information is added with the name
maybe a simple "current" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
