dsmiley commented on a change in pull request #115:
URL: https://github.com/apache/solr/pull/115#discussion_r631352608
##########
File path: solr/core/src/java/org/apache/solr/servlet/SolrRequestParsers.java
##########
@@ -171,23 +173,50 @@ public SolrQueryRequest parse( SolrCore core, String
path, HttpServletRequest re
ArrayList<ContentStream> streams = new ArrayList<>(1);
SolrParams params = parser.parseParamsAndFillStreams( req, streams );
- Span span = (Span) req.getAttribute(Span.class.getName()); // not null but
maybe in some tests?
- if (span != null && !(span instanceof NoopSpan)) {
- span.setTag("params", params.toString());
- }
SolrQueryRequest sreq = buildRequestFrom(core, params, streams,
getRequestTimer(req), req);
// Handlers and login will want to know the path. If it contains a ':'
// the handler could use it for RESTful URLs
- sreq.getContext().put(PATH, RequestHandlers.normalize(path));
+ String pathNormalized = RequestHandlers.normalize(path);
+ sreq.getContext().put(PATH, pathNormalized);
sreq.getContext().put("httpMethod", req.getMethod());
if(addHttpRequestToContext) {
sreq.getContext().put("httpRequest", req);
}
+
+ // add span info
+ TraceUtils.ifNotNoop(
Review comment:
In my most recent commit, I moved the logic to a method on HttpSolrCall
and thus it becomes a method reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
