alessandrobenedetti opened a new pull request #129: URL: https://github.com/apache/solr/pull/129
# Description sow=false should not split on whitespace and build field queries with the entire query text. It's the responsibility of each field query text analysis to manage tokenization if any. Currently this doesn't happen for not textual fields such as string, numerical. It's up to discussion if we want to apply tokenization to numerical, even with sow=false # Solution no tokenization happens if the field is not textual # Tests There are old tests that have been corrected as their behaviour was incorrect, with sow=false in my opinion. There is a org.apache.solr.search.TestExtendedDismaxParser#testFocusQueryParser that is up for discussion in relation to numerical fields. # Checklist Please review the following and check all that apply: - [ X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ X] I have created a Jira issue and added the issue ID to my pull request title. - [ X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ X] I have developed this patch against the `main` branch. - [X ] I have run `./gradlew check`. - [X ] I have added tests for my changes. - [X ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
