[
https://issues.apache.org/jira/browse/SOLR-14245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346826#comment-17346826
]
Andrzej Bialecki commented on SOLR-14245:
-----------------------------------------
bq. how can deal with our attitude of not caring about users who may be
affected by bugs or changes we introduce
[~ichattopadhyaya] and [~noble.paul]: I'm totally fed up with your ad hominem
attacks. Please discuss this in a civil manner. If I were so inclined I could
also point fingers to many areas of code where you both rammed through totally
buggy and sloppy code, and start implying you're ignorant and careless. I could
also find many significant changes you guys did without PRs or with a PR opened
and committed within a couple hours, without any review.
But I hope that ultimately we all have good intentions and we should fight the
problem and not each other. On second thought, I agree with Noble that the
validation should be more lenient (incidentally, the bug that causes
{{node_name: null}} is likely related to a buggy roundtrip conversion between
ReplicaInfo <-> Replica... and guess who added ReplicaInfo?).
I still object to removing the validation completely, but we can make it
non-fatal - as I said above, admins should be aware when Solr is using
corrupted data, because we really can't be sure what other long-term
consequences it may cause.
> Validate Replica / ReplicaInfo on creation
> ------------------------------------------
>
> Key: SOLR-14245
> URL: https://issues.apache.org/jira/browse/SOLR-14245
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Priority: Minor
> Fix For: 8.5
>
>
> Replica / ReplicaInfo should be immutable and their fields should be
> validated on creation.
> Some users reported that very rarely during a failed collection CREATE or
> DELETE, or when the Overseer task queue becomes corrupted, Solr may write to
> ZK incomplete replica infos (eg. node_name = null).
> This problem is difficult to reproduce but we should add safeguards anyway to
> prevent writing such corrupted replica info to ZK.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
