dsmiley commented on a change in pull request #130:
URL: https://github.com/apache/solr/pull/130#discussion_r634719663
##########
File path:
solr/solrj/src/java/org/apache/solr/common/cloud/ZkMaintenanceUtils.java
##########
@@ -33,8 +33,8 @@
import java.util.function.Predicate;
import java.util.regex.Pattern;
-import org.apache.commons.lang.StringUtils;
import org.apache.solr.client.solrj.SolrServerException;
+import org.apache.solr.common.StringUtils;
Review comment:
Was the removal of the commons-lang 2.6 dependency tied _only_ to this
file or was the older ZooKeeper using it? If it was only this file, the PR
should have been split. And FYI Solr depends on Commons-Lang-3 so StringUtils
is there as well and has these methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
