gerlowskija commented on pull request #81: URL: https://github.com/apache/solr/pull/81#issuecomment-851110170
I've finished the APIs themselves and have tests for each of the v1->v2 conversions. The last thing to be done here I think is splitting up the API commands into separate classes as per @dsmiley's feedback. On that note - there's a bug that complicates doing this right now. Each API class is registered individually by "ApiBag", which stores an Api object per HTTP method, per path. When all commands for a given method and path are in the same class - this works well. When commands for that method and path are split across different classes though - the registration for each one overrides the registrations before it. I've highlighted the line where this happens [here](https://github.com/apache/solr/pull/81/files#diff-20733c59d42a1a1a2b4164485888dc067db372fa2c7fdffb30d48c04ae2bed74R168), and suggested a few workarounds. All of them seem a bit hacky at first glance. Maybe one of the suggestions there is good enough, but I don't have tons of context on ApiBag (and the PathTrie class it relies on) and need to give it a bit more thought to know which is best. @noblepaul any suggestions on the best way to handle this? Or am I missing something else that'd get me around this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
