epugh commented on a change in pull request #91:
URL: https://github.com/apache/solr/pull/91#discussion_r645063187



##########
File path: solr/solr-ref-guide/src/coreadmin-api.adoc
##########
@@ -50,6 +94,45 @@ The `CREATE` action creates a new core and registers it.
 If a Solr core with the given name already exists, it will continue to handle 
requests while the new core is initializing. When the new core is ready, it 
will take new requests and the old core will be unloaded.
 
 
`admin/cores?action=CREATE&name=_core-name_&instanceDir=_path/to/dir_&config=solrconfig.xml&dataDir=data`
+[.dynamic-tabs]
+--
+[example.tab-pane#v1coreadmin-create]
+====
+[.tab-label]*V1 API*
+
+Assuming you are using an existing configSet to create your new core:
+[source,bash]
+----
+http://localhost:8983/solr/admin/cores?action=CREATE&&name=techproducts_v2&configSet=sample_techproducts_configs
+
+----
+
+If you have already existing core files deployed on disk, and need to just 
create the Solr core from them then the url will look something like
+[source,bash]
+----
+admin/cores?action=CREATE&name=_core-name_&instanceDir=_path/to/dir_&config=solrconfig.xml&dataDir=data
+----
+====
+
+[example.tab-pane#v2coreadmin-create]
+====
+[.tab-label]*V2 API*
+
+Assumes SOLR-15372 is committed.
+
+[source,bash]
+----
+curl -X POST http://localhost:8983/api/cores -H 'Content-Type: 
application/json' -d'

Review comment:
       it seems to work!   We have 32 instances of `-d'` and 152 of `-d '` so I 
will put the space in...   

##########
File path: solr/solr-ref-guide/src/coreadmin-api.adoc
##########
@@ -50,6 +94,45 @@ The `CREATE` action creates a new core and registers it.
 If a Solr core with the given name already exists, it will continue to handle 
requests while the new core is initializing. When the new core is ready, it 
will take new requests and the old core will be unloaded.
 
 
`admin/cores?action=CREATE&name=_core-name_&instanceDir=_path/to/dir_&config=solrconfig.xml&dataDir=data`
+[.dynamic-tabs]
+--
+[example.tab-pane#v1coreadmin-create]
+====
+[.tab-label]*V1 API*
+
+Assuming you are using an existing configSet to create your new core:
+[source,bash]
+----
+http://localhost:8983/solr/admin/cores?action=CREATE&&name=techproducts_v2&configSet=sample_techproducts_configs
+
+----
+
+If you have already existing core files deployed on disk, and need to just 
create the Solr core from them then the url will look something like
+[source,bash]
+----
+admin/cores?action=CREATE&name=_core-name_&instanceDir=_path/to/dir_&config=solrconfig.xml&dataDir=data
+----
+====
+
+[example.tab-pane#v2coreadmin-create]
+====
+[.tab-label]*V2 API*
+
+Assumes SOLR-15372 is committed.

Review comment:
       I've tried a couple of workarounds, and no joy, so just going to take 
out the comment, and leave it...

##########
File path: solr/solr-ref-guide/src/schema-api.adoc
##########
@@ -112,7 +93,7 @@ curl -X POST -H 'Content-type:application/json' 
--data-binary '{
      "name":"sell_by",
      "type":"pdate",
      "stored":true }
-}' http://localhost:8983/solr/gettingstarted/schema
+}' http://localhost:8983/solr/techproducts/schema

Review comment:
       I end up using techproducts a lot to test things, and a way to learn 
about the apis.    As long as you are okay (i.e -0) with it, then I'll leave it 
with techproducts.  Thanks for the comment Cassandra!

##########
File path: solr/solr-ref-guide/src/schema-api.adoc
##########
@@ -844,12 +827,27 @@ If `multiValued` is defined as either true or false (most 
likely true), that wil
 
 ==== List Fields Examples
 
-Get a list of all fields.
+[.dynamic-tabs]
+--
+[example.tab-pane#v1list-fields]
+====
+[tab-label]*V1 API*
+[source,bash]
+----
+http://localhost:8983/techproducts/schema/fields
+----
+====
 
+[example.tab-pane#v2list-fields]
+====
+[tab-label]*V2 API*
 [source,bash]
 ----
-curl http://localhost:8983/solr/gettingstarted/schema/fields
+
+curl -X GET 
"http://localhost:8983/api/collections/techproducts/schema/fields?wt=json";

Review comment:
       I don't know why I thought I was getting xml!   I really appreciate the 
eagle eyes...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to