[
https://issues.apache.org/jira/browse/SOLR-15465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360724#comment-17360724
]
Jan Høydahl commented on SOLR-15465:
------------------------------------
> If you really don't like the test dependencies, you could comment out/remove
>the two test configurations I pointed at; this would only leave non-test
>dependencies. See how many you have then.
That was exactly what I did to find the diff. Removing the two test classpaths
will make the check complain about 48 files that are not referenced.
Filtering during distribution assembly would satisfy my concern for what we
ship I guess. Would be a bonus to simplify the manual work needed to record the
license for test deps too. I wonder whether maven automates this by looking up
the license in maven central - it contains license information, right?
> Do not require LICENSE and NOTICE files for test-dependencies
> -------------------------------------------------------------
>
> Key: SOLR-15465
> URL: https://issues.apache.org/jira/browse/SOLR-15465
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Build
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Priority: Major
>
> Our current build (and the ant build before it) checks that every single jar,
> even test dependencies, have a .sha1 file in licenses/ folder along with a
> LICENSE file and optinally a NOTICE file.
> However, according to [https://infra.apache.org/licensing-howto.html] we only
> need to supply LICENSE/NOTICE files for bits we ship, either as copy/pasted
> source code in the source dist or jar deps in the binary dist.
> Thus, I think we can stop shipping those LICENSE/NOTICE files for deps that
> we never distribute. Perhaps the sha1 files should remain for extra
> validation of binaries pulled from mvn, I don't know.
> [~dsmiley] [~dweiss]
> This probably goes for the Lucene build too.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
