cpoerschke commented on a change in pull request #169:
URL: https://github.com/apache/solr/pull/169#discussion_r651258643
##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java
##########
@@ -77,38 +77,26 @@ public Tuple() {
* A copy constructor.
* @param fields map containing keys and values to be copied to this tuple
*/
- public Tuple(Map<?, ?> fields) {
- for (Map.Entry<?, ?> entry : fields.entrySet()) {
- put(entry.getKey(), entry.getValue());
- }
+ public Tuple(Map<String, ?> fields) {
+ this.fields.putAll(fields);
+ EOF = this.fields.containsKey(StreamParams.EOF);
+ EXCEPTION = this.fields.containsKey(StreamParams.EXCEPTION);
Review comment:
> ... I can back this change out and leave a note for a future JIRA if
you'd prefer.
That would be my preference, yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
