cpoerschke commented on a change in pull request #151:
URL: https://github.com/apache/solr/pull/151#discussion_r656426767
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java
##########
@@ -185,6 +187,8 @@ public void prepare(ResponseBuilder rb) throws IOException
if(rq instanceof RankQuery) {
RankQuery rankQuery = (RankQuery)rq;
rb.setRankQuery(rankQuery);
+ // we always need the score for reRanking
+ rb.setFieldFlags(rb.getFieldFlags() | GET_SCORES);
Review comment:
Great point. How about something along these lines?
```
int flags = 0; // we presume to be first to set this flag and hereby
override any flags other components' prepare methods may have already set
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
