cpoerschke commented on a change in pull request #189:
URL: https://github.com/apache/solr/pull/189#discussion_r658150302
##########
File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java
##########
@@ -186,18 +191,40 @@ public void scoreFeatures(IndexSearcher indexSearcher,
docBase = readerContext.docBase;
scorer = modelWeight.scorer(readerContext);
}
- scoreSingleHit(indexSearcher, topN, modelWeight, docBase, hitUpto, hit,
docID, scoringQuery, scorer, reranked);
+ scoreSingleHit(
Review comment:
hmm, yeah, ten arguments for the method is also quite a lot, perhaps a
different method signature somehow with an intermediate structure or something.
would need to give it some thought (beyond reformatting code that is)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
