Mike Drob created SOLR-15503:
--------------------------------
Summary: Record current number of warnings and fail the build if
that number is exceeded
Key: SOLR-15503
URL: https://issues.apache.org/jira/browse/SOLR-15503
Project: Solr
Issue Type: Task
Security Level: Public (Default Security Level. Issues are Public)
Reporter: Mike Drob
As part of the warning elimination/reduction work I'm doing in SOLR-15385, I'd
like to add some precommit validation to check if the current number of
suppressions exceed the known amount. We can then continue to ratchet this
down, although I know we will never reach zero.
I was thinking about doing this inside of validateSourcePatterns, but I'm not
sure of how to do this in an incremental way. Essentially, I want to run {{git
grep SuppressWarn | wc -l}} and compare that output to some saved value, if
higher then fail, if lower then suggest that the saved number needs to be
adjusted. Also, we can be more specific, like have separate thresholds for
different kinds of suppression annotations, so that we don't just trade one for
another blindly.
[~dawid.weiss] - any suggestions are appreciated. Thanks!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
