[
https://issues.apache.org/jira/browse/SOLR-15124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17371877#comment-17371877
]
Nazerke Seidan edited comment on SOLR-15124 at 6/30/21, 8:07 AM:
-----------------------------------------------------------------
I created PR on the main branch.
But I run tests locally and there are test failures in ThreadDumpHandlerTest,
PropertiesRequestHandlerTest and LoggingHandlerTest. As I removed these admin
handlers at the core level, wondering if I should remove these tests as well?
was (Author: nazerke):
I created PR on the main branch.
But I run tests locally and there are test failures in `ThreadDumpHandlerTest`,
`PropertiesRequestHandlerTest` and `LoggingHandlerTest`. As I removed these
admin handlers at the core level, wondering if I should remove these tests as
well?
> Remove node/container level admin handlers from ImplicitPlugins.json (core
> level).
> ----------------------------------------------------------------------------------
>
> Key: SOLR-15124
> URL: https://issues.apache.org/jira/browse/SOLR-15124
> Project: Solr
> Issue Type: Task
> Reporter: David Smiley
> Priority: Blocker
> Labels: newdev
> Fix For: main (9.0)
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> There are many very old administrative RequestHandlers registered in a
> SolrCore that are actually JVM / node / CoreContainer level in nature. These
> pre-dated CoreContainer level handlers. We should (1) remove them from
> ImplictPlugins.json, and (2) make simplifying tweaks to them to remove that
> they work at the core level. For example LoggingHandler has two constructors
> and a non-final Watcher because it works in these two modalities. It need
> only have the one that takes a CoreContainer, and Watcher will then be final.
> /admin/threads
> /admin/properties
> /admin/logging
> Should stay because has core-level stuff:
> /admin/plugins
> /admin/mbeans
> This one:
> /admin/system -- SystemInfoHandler
> returns "core" level information, and also node level stuff. I propose
> splitting this one to a CoreInfoHandler to split the logic. Maybe a separate
> issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
