cpoerschke commented on a change in pull request #193:
URL: https://github.com/apache/solr/pull/193#discussion_r665496641
##########
File path: solr/core/src/java/org/apache/solr/core/SolrConfig.java
##########
@@ -357,7 +357,7 @@ public static final Version parseLuceneVersionString(final
String matchVersion)
.add(new SolrPluginInfo(IndexSchemaFactory.class, "schemaFactory",
REQUIRE_CLASS))
.add(new SolrPluginInfo(RestManager.class, "restManager"))
.add(new SolrPluginInfo(StatsCache.class, "statsCache", REQUIRE_CLASS))
- .add(new SolrPluginInfo(CircuitBreakerManager.class, "circuitBreaker"))
+ .add(new SolrPluginInfo(CircuitBreakerManager.class, "circuitBreaker",
MULTI_OK))
Review comment:
Thanks for clarifying that circuit breakers are individually pluggable
but the circuit breaker manager is no longer pluggable!
Would you be comfortable with me adding commits to the pull request branch?
I've tried out experimentally to use `CircuitBreaker.class` instead of
`CircuitBreakerManager.class` and also some other suggestions more easily
shared in code instead of comment form e.g. use of the PluginInfo's built-in
enable(d) attribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
