[ 
https://issues.apache.org/jira/browse/SOLR-15485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378385#comment-17378385
 ] 

David Smiley commented on SOLR-15485:
-------------------------------------

The anti-pattern corrected in this issue occurred in only a few class files 
(maybe by the same person and/or copy-paste ?); I don't expect this oddity 
spread further.   Is it really worth adding a regexp to 
validate-source-patterns.gradle over that?
See the conversation here: 
https://issues.apache.org/jira/browse/LUCENE-10003?focusedCommentId=17376753&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17376753
CC [~uschindler]

> discourage Collections.singleton.forEach use
> --------------------------------------------
>
>                 Key: SOLR-15485
>                 URL: https://issues.apache.org/jira/browse/SOLR-15485
>             Project: Solr
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>             Fix For: main (9.0), 8.10
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> For example
> {code}
> Collections.singleton(foo).parallelStream().forEach(c -> { c.bar(); });
> {code}
> or
> {code}
> Collections.singleton(foo).stream().forEach(c -> { c.bar(); });
> {code}
> should typically be equivalent to
> {code}
> foo.bar();
> {code}
> which is more concise.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to