madrob commented on a change in pull request #207:
URL: https://github.com/apache/solr/pull/207#discussion_r667416969
##########
File path: solr/core/src/java/org/apache/solr/search/CacheConfig.java
##########
@@ -116,12 +116,10 @@ public static CacheConfig getConfig(SolrConfig
solrConfig, String xpath) {
}
- @SuppressWarnings({"unchecked"})
public static CacheConfig getConfig(SolrConfig solrConfig, String nodeName,
Map<String,String> attrs, String xpath) {
CacheConfig config = new CacheConfig();
config.nodeName = nodeName;
- @SuppressWarnings({"rawtypes"})
- Map attrsCopy = new LinkedHashMap<>(attrs.size());
+ Map<String,String> attrsCopy = new LinkedHashMap<>(attrs.size());
for (Map.Entry<String, String> e : attrs.entrySet()) {
attrsCopy.put(e.getKey(), String.valueOf(e.getValue()));
Review comment:
This would be different when value is null, so I didn't want to change
it. Might not matter, but I figured it's ok to leave the extra method call for
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
