benediktarnold commented on a change in pull request #212:
URL: https://github.com/apache/solr/pull/212#discussion_r668499091
##########
File path:
solr/core/src/test/org/apache/solr/search/SignificantTermsQParserPluginTest.java
##########
@@ -17,19 +17,130 @@
package org.apache.solr.search;
+import org.apache.commons.io.FileUtils;
import org.apache.solr.SolrTestCaseJ4;
+import org.apache.solr.common.SolrInputDocument;
+import org.apache.solr.common.params.MapSolrParams;
+import org.apache.solr.common.params.ModifiableSolrParams;
+import org.apache.solr.core.SolrCore;
+import org.apache.solr.handler.component.ResponseBuilder;
+import org.apache.solr.request.LocalSolrQueryRequest;
+import org.apache.solr.request.SolrQueryRequest;
+import org.apache.solr.response.SolrQueryResponse;
+import org.apache.solr.update.AddUpdateCommand;
+import org.apache.solr.update.CommitUpdateCommand;
+import org.apache.solr.update.DeleteUpdateCommand;
+import org.apache.solr.util.RefCounted;
+import org.junit.BeforeClass;
import org.junit.Test;
+import java.io.File;
+import java.io.IOException;
+import java.util.*;
+
public class SignificantTermsQParserPluginTest extends SolrTestCaseJ4 {
- /**
- * Test the backwards compatibility for a typo in the
SignificantTermsQParserPlugin. It will fail if the backwards
- * compatibility is broken.
- */
- @Test
- public void testQParserBackwardsCompatibility() {
- assertEquals("significantTerms", SignificantTermsQParserPlugin.NAME);
- assertEquals(SignificantTermsQParserPlugin.class,
-
QParserPlugin.standardPlugins.get(SignificantTermsQParserPlugin.NAME).getClass());
- }
+ @BeforeClass
+ public static void setUpCore() throws Exception {
+ String tmpSolrHome = createTempDir().toFile().getAbsolutePath();
+ FileUtils.copyDirectory(new File(TEST_HOME()), new
File(tmpSolrHome).getAbsoluteFile());
+ initCore("solrconfig.xml", "schema.xml", new
File(tmpSolrHome).getAbsolutePath());
+ }
+
+ /**
+ * Test the backwards compatibility for a typo in the
SignificantTermsQParserPlugin. It will fail if the backwards
+ * compatibility is broken.
+ */
+ @Test
+ public void testQParserBackwardsCompatibility() {
+ assertEquals("significantTerms", SignificantTermsQParserPlugin.NAME);
+ assertEquals(SignificantTermsQParserPlugin.class,
+
QParserPlugin.standardPlugins.get(SignificantTermsQParserPlugin.NAME).getClass());
+ }
+
+ @Test
+ public void testEmptyCollectionDoesNotThrow() throws Exception {
+ SolrCore emptyCore = h.getCore();
+ QParserPlugin qParserPlugin =
QParserPlugin.standardPlugins.get(SignificantTermsQParserPlugin.NAME);
+ Map<String, String> params = new HashMap<>();
+ params.put("field", "cat");
+ QParser parser = qParserPlugin.createParser("", new
MapSolrParams(params), new MapSolrParams(new HashMap<>()), null);
+ AnalyticsQuery query = (AnalyticsQuery) parser.parse();
Review comment:
`SignificantTermsQuery` is a private class and can't be used in the
test. Should I change the visibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
