[
https://issues.apache.org/jira/browse/SOLR-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380030#comment-17380030
]
Houston Putman commented on SOLR-15335:
---------------------------------------
[~hossman], while adding the license headers to the generated dockerfiles, I
noticed that the {{createDockerfileOfficial}} and {{createDockerfileLocal}}
tasks are still cached even if the {{createBodySnippetDockerfile}} task runs,
and updates the body snippet.
The fix is pretty easy, merely adding the following in the
{{createDockerfile*}} task:
{{inputs.file("$buildDir/snippets/Dockerfile.body.snippet")}}
Gonna create a very small patch with the fix, let me know if it looks good to
you.
> templated (header + body) approach for building Dockerfile.local +
> Dockerfile.official w/common guts
> ----------------------------------------------------------------------------------------------------
>
> Key: SOLR-15335
> URL: https://issues.apache.org/jira/browse/SOLR-15335
> Project: Solr
> Issue Type: Sub-task
> Components: Docker
> Reporter: Chris M. Hostetter
> Assignee: Chris M. Hostetter
> Priority: Major
> Fix For: main (9.0)
>
> Attachments: SOLR-15335-no-custom-network.patch, SOLR-15335.patch,
> SOLR-15335.patch, SOLR-15335.patch, SOLR-15335.patch, SOLR-15335.patch,
> SOLR-15335.patch, SOLR-15335.patch, SOLR-15335.patch, SOLR-15335.patch
>
>
> Goals:
> * "generate" a Dockerfile.official at release time that will satisfy the
> process/tooling of docker-library for 'official' docker images
> ** use a templated approach to fill in things like version, sha512, and GPG
> fingerprint
> * ensure that the generated Dockerfile.official and the Dockerfile.local
> included in solr.tgz are identical in terms of the "operational" aspects of a
> Solr docker image (ie: what the disk layout looks like, and how it runs)
> ** they should only differ in how they get the contents of a solr.tgz into
> the docker image (and how much they trust it before unpacking it)
> * minimize the amount of overhead needed to make changes that exist in in
> both dockerfiles
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
