HoustonPutman commented on a change in pull request #292:
URL: https://github.com/apache/solr-operator/pull/292#discussion_r675186183
##########
File path: api/v1beta1/solrcloud_types.go
##########
@@ -1106,6 +1141,47 @@ type SolrTLSOptions struct {
// Opt-in flag to restart Solr pods after TLS secret updates, such as
if the cert is renewed; default is false.
// +optional
RestartOnTLSSecretUpdate bool
`json:"restartOnTLSSecretUpdate,omitempty"`
+
+ // Used to specify a path where the keystore, truststore, and password
files are mounted by an external agent or CSI driver.
+ // This option is typically used with a `restartSchedule` to restart
Solr pods before the mounted TLS cert expires.
Review comment:
```suggestion
// This option is typically used with
`spec.updateStrategy.restartSchedule` to restart Solr pods before the mounted
TLS cert expires.
```
##########
File path: controllers/util/solr_util.go
##########
@@ -1390,12 +1434,13 @@ func generateSecurityJson(solrCloud *solr.SolrCloud)
map[string][]byte {
%s,
{ "name": "k8s-status", "role":"k8s", "collection": null,
"path":"/admin/collections" },
{ "name": "k8s-metrics", "role":"k8s", "collection": null,
"path":"/admin/metrics" },
+ { "name": "k8s-zk", "role":"k8s", "collection": null,
"path":"/admin/zookeeper/status" },
Review comment:
You mind if we fix these in a separate small PR?
##########
File path: controllers/util/solr_util.go
##########
@@ -101,7 +101,7 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud,
solrCloudStatus *solr.SolrCl
defaultMode := int32(420)
probeScheme := corev1.URISchemeHTTP
- if solrCloud.Spec.SolrTLS != nil {
+ if solrCloud.UrlScheme() == "https" {
Review comment:
this is going to conflict with the Ingress TLS Termination PR. When it
does, just change this to `SolrCloud.UrlScheme(false)` (getting url scheme
internal in the cluster)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
