madrob commented on a change in pull request #230:
URL: https://github.com/apache/solr/pull/230#discussion_r676963773
##########
File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java
##########
@@ -804,15 +807,29 @@ public BitDocSet getDocSetBits(Query q) throws
IOException {
}
// only handle positive (non negative) queries
- DocSet getPositiveDocSet(Query q) throws IOException {
- DocSet answer;
- if (filterCache != null) {
- answer = filterCache.get(q);
- if (answer != null) return answer;
+ DocSet getPositiveDocSet(Query query) throws IOException {
+ // TODO duplicated code with getDocSet, can maybe also use FutureDocSet
here
+ boolean doCache = filterCache != null;
Review comment:
Very possible that I had other changes here before and then I had to
back some of them out due to failing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
