markrmiller commented on pull request #235: URL: https://github.com/apache/solr/pull/235#issuecomment-887102668
Very nice. Not the only place someone favored a new StringBuilder over setLength(0) or did not size it. Adds up, especially with a util call like this that can happen in loops. CharBuffer and StringBuilder have sim perf with small data, but then CharBuffer pulls ahead, so that is also a winner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
